Hacker News Reader

Hacker News

Comment by vespakoen | Hacker News Reader

Parent Full thread

vespakoen

(bit offtopic) but what about:

module.exports = function leftpad (str, len, ch) { return Array(len).join(ch || ' ') + String(str); };

View on HN

Almost, but the existing code only pads when the str length is less than that of len.

Ahh you are right, all makes sense now, thanks!

You need to go something like:

  module.exports = function leftpad (str, len, ch) { return Array(Math.max(0, len - String(str).length)).join(ch || ' ') + String(str); };

Unfortunately we need to wrap str twice so maybe a one-liner is not quite in place.

Also, this doesn't support zero padding with ch=0.

Cool, I like the Math.max. Two liner then str = String(str);\n...

So this I guess

module.exports = function leftpad (str, len, ch) { str = String(str); if (ch === 0) { ch = '0'; } return Array(Math.max(0, len - str.length)).join(ch || ' ') + str; };

And I did not notice the 0 check in the original code either :-D

The array + join is slower

http://jsperf.com/leftpadtesting

Repeat + slice is too

http://jsperf.com/leftpad

Reply on news.ycombinator.com