The advice here recommends generating an RSA keys. Mozilla recommend using ED25519 keys "when backwards compatibility is not required" [1]
[1] https://wiki.mozilla.org/Security/Guidelines/OpenSSH#Key_gen...
[1] https://wiki.mozilla.org/Security/Guidelines/OpenSSH#Key_gen...