I agree that port knocking is not the christ child. It will not solve world hunger nor will it allow the wolves to lay down with the lambs.
But it's something.
But it's something.
Edit: heh, same thing is going on a few comments down :)
You have to decide if the tradeoff between a thousand bot's scans and a sole eavesdropper noticing the knocking pattern and marking your host as "(incompetently) trying to hide" is really worth it.
Not true. Modern port knocking is provably secure and requires network layer attacks to bypass.