Is the 80 col limit still valid in the modern day with such large screen displays? . His line indentation convention is inconsistent. In one place he says to use 8 spaces, in another he says to use 4. Then when you look at a switch, its 0. . variable declarations: If he's referring to the way that JSLint enforces it, that's stupid. ex:
function foo(){
myGlobal = "foo";
}
var myGlobal;
Yes, but not in the way that JSLint enforces it. See above.
"Inner functions should follow the var statement."
umm, no? This has a different meaning from a function declaration.
"Do not use _ (underbar) as the first character of a name. It is sometimes used to indicate privacy, but it does not actually provide privacy. "
It's private because you weren't invited to use it, not because I have a bomb waiting for you.
"If privacy is important, use the forms that provide private members. Avoid conventions that demonstrate a lack of competence."
Whatever, show me an efficient, non-convoluted pattern that allows inheritance of privileged members. Avoid conventions that demonstrate a lack of concern for memory consumption and efficiency.
"Global variables should be in all caps."
umm, no. That convention is reserved for constants.
"Each group of statements (except the default) should end with break, return, or throw. Do not fall through."
Arbitrary. I think DRY is preferable when it's warranted.
"Avoid use of the continue statement. It tends to obscure the control flow of the function. "
It's ok to use labels, but not continue? I don't understand this logic.
"Avoid doing assignments in the condition part of if and while statements. "
It's a legitimate convention if wrapped with an extra pair of parenthesis. Note that Mozilla's strict mode will honor this convention.