Hacker News Reader

Comment by Zombieball | Hacker News Reader

I expected a long rant about storing all your passwords in one place. First paragraph I see reference to php, and completely sympathized with the author

And I am a LastPass customer!

(edit: clarification, I meant to portray my disdain for php. I still like (and trust) LastPass!)

View on HN

Modern PHP (which LastPass almost certainly isn't using or writing) isn't really worthy of disdain.

https://github.com/paragonie/halite/blob/master/src/Symmetri...

(Disclaimer: My project.)

Just a heads up comments like these don't really say anything useful. I know you're splitting keys because that's what the function is called. What the keys are or why they're being split is what the comment should mention.

        // Split our keys
        list($encKey, $authKey) = self::splitKeys($secretKey, $salt, $config);

Also what's happening here? This could do with a comment for more junior devs. It's impossible to Google "function with a colon on the end of it in php"

   public static function decrypt( [..] ): HiddenString { [..] }

Edit: Re-phrased my wording to be a bit less boorish

> Just a heads up comments like these don't really say anything useful.

Thanks for looking through the code. I'll make the comments more meaningful on my next run through.

> Also what's happening here? This could do with a comment for more junior devs. It's impossible to Google "function with a colon on the end of it in php"

That's a PHP 7 feature called return type declarations. If it doesn't return an instance of HiddenString, PHP will throw a TypeError.

Oh no I mean if we shrink it down to the PHP it becomes public static function decrypt(): HiddenString { }

The way I worded it is implying I'm digging at you sorry. I mean the literal what does this do, I've not come across formatting things like this before

You're fine, I just didn't understand your question on the first pass.

EDIT: https://github.com/paragonie/halite/compare/v3.1.1...3b95d85...

Cheers - I need to read up and play some more with PHP 7. The joys of maintaining a 5.6 world :)

Reply on news.ycombinator.com