Hacker News Reader

I have been told that the code I write is ugly, multiple times by different people.

The only time this has ever bothered me is when it's in the interview process and costs me the job.

I usually stop working on code when it's "good enough", which is to say, when it works.

Maybe I have low standards.

Sometimes good enough is best, and other times a refactoring is worth it. Key is to think of it from a business point of view. If you always refactor or never refactor, both extremes are suboptimal IMO. Deciding when a quick fix is good vs. something more considered is an art.

depends on the actual code. I work with someone who likes to code by "works on my machine, in my limited tests, ship it, if it breaks then fix it" which is terrible since this person isn't on call and wouldn't have to deal with the fall out.

It gets picked up in review, but the attitude is unfortunate.

If your code is ugly by stylistic preferences but works and you are a responsible coworker, then, meh, I'd only code review in changes if they were pertinent to the issue being solved.

Reply on news.ycombinator.com