Right to repair should only apply to hardware. Anything software related is fair game for hacking/reversing. Otherwise it is like asking Apple to provide the special screwdriver that opens the special screws they designed to keep the world out of their walled garden. Apple should not be compelled to provide that special screwdriver and at the same time no other vendor, who has reversed the design, be prevented from selling it to interested users. You buy that tool, but the moment you apply it to an iPhone, all warranty from Apple is null and void.

User info should be locked away by the entity to whom the information was entrusted in the first place. In this case Apple. Yes, if you buy an iPhone and use it access/generate information then it is by definition already entrusted to Apple. Don't like it? Don't buy an iPhone. Better yet, go use a self-built Linux PC. Forgo smart phones altogether.

Except the only lock Apple has placed is to prevent compromising your TouchID/secure enclave data, which is understandable. They're not locking you out of repairing other components like screens, batteries.

No - you've misunderstood- Apple hasn't put any locks in place to prevent repair. Any 'locks' are to prevent compromise.