The Spanish constitution won't change because it's in their best interest to not do so, which is why this illegal referendum is being created. If they wanted the Estatut to pass, they would have passed; they didn't pass it because the rest of the Spanish communities would have been affected by it from an economical point of view (suddenly a chunk of money that was going to the other communities stays in Catalonia. Guess who's gonna be unhappy).
As to when you stop with the right of self-determination, in the case of Catalonia, from a cultural, language, and historical point of view, there's enough reasons for a referendum to be held (given the discontent of the population). There's a similar situation with Quebec, for example. As far as I know, there's nothing about New York --language, history, or culture-- that would warrant a referendum, and there's certainly no reason for you as an individual to do so (you don't even have the basic political institutions).