Security Advisory for rustdoc
blog.rust-lang.org
blog.rust-lang.org
I suppose this serves as a nice PSA and fire drill for the security team.
The only two previous vulnerabilities we had were in crates.io, and this has already exposed some interesting aspects of how we handle these kinds of things. If we have to have a security bug, this is exactly the kind I'd prefer to have.
> It’s worth noting that while Rust does prevent a lot of issues in your code at compile time, they’re issues that result from memory unsafety. This bug is a logic error. Rust code is not inherently secure, or bug-free. Sometimes, people get enthusiastic and make overly-broad claims about Rust, and this incident is a good demonstration of how Rust’s guarantees can’t prevent all bugs.
* You're using this totally undocumented feature. This involves somehow fabricating a plugin that will actually load, which is non-trivial. Pretty sure you have to copy the appropriate types out of the source of Rust itself, and build things that way.
* You're also relying specifically on the fallback location
* You're doing this on a computer with other users
When you pass either of the flags in question, it prints out a message saying "hey, this feature is deprecated, please comment on this github issue if you're using it" and has gotten zero comments in a full year.
Never say never, but the chances of this affecting anyone are extremely remote.
If it just loaded them without the user needing to also use a flag, the chances would go way up, for sure.
I’ll re-work the wording when I’m at a computer, thanks :)
I was in a rush to get it out the door before I went off to start college, and I guess I never removed my testing path from the code. Oops!
It was fun getting the email this morning and reminiscing ;)
It's supremely disappointing that a brand new language/platform like rust suffers from the same classic security mistakes that we keep finding in old software. You normally expect to see these types of things in stuff like Bash that has been around for so long nobody has taken time to review lots of its code with a more modern thread level.