I think the iSmell, at least the way it's described in the article, was a terrible idea. Whatever the scent-enabled equivalent of a Rickroll or a goatse link would have been, we're better off without it.
That said, the technology seems kind of cool. The idea that we could define a set of primitive smells, then combine them into any other arbitrary smell is fascinating. If you have the binary data from an image file, and you know how to decode it, you can preserve a photograph forever -- potentially for thousands of years -- with no degradation. It would be really great to be able to preserve scents for posterity in the same way.