Hacker News Reader

Comment by aldanor | Hacker News Reader

Indeed, what's the point to ask someone to write a fizzbuzz when it's already been done to the highest of professional enterprise standards! [1]

[1] https://github.com/EnterpriseQualityCoding/FizzBuzzEnterpris...

View on HN

Highest professional enterprise standards my arse. Where's the message queues? Why isn't there a Fizz microservice and a Buzz microservice that live behind an API Gateway and receive messages from an event driven architecture?

I'm gonna need a write up. I've been looking at the code for 10 or 15 minutes and I still haven't found "fizz", "buzz", or the number 100 anywhere in the code. It's amazing.

Found it!!

https://github.com/EnterpriseQualityCoding/FizzBuzzEnterpris...

I have no idea either, but those are "constants", and so it is only logical that they belong in com.seriouscompany.business.java.fizzbuzz.packagenamingpackage.impl.Constants (https://github.com/EnterpriseQualityCoding/FizzBuzzEnterpris...).

I think it’s really shortsighted to hardcode them statically into constants. You’d have to build a completely new binary should the requirements someday change! Obviously they belong behind a configuration interface, an instance of which can then be dependency injected to places that need them. In this way you can easily supply them from whatever source you like, such as a properties file, XML document, a database or even a web service.

As it is now, 2/10 would not pass review.

Sounds like Spring ConfigurationProperties https://docs.spring.io/spring-boot/docs/current/reference/ht...

I'm utterly unsurprised.

IsEvenlyDivisibleStrategyFactory.java ... now I remember why I hate java.

Needs more AWS Lambda, this is outdated.

Reply on news.ycombinator.com