There are e-cigs that do smell, the one in my previous company "vaping" in the open space used some kind of flavor that had a strong [unpleasant] smell, even over 5 meters away.
Overall it's a great improvement. I just hope this improvement doesn't come with regressions (more [e-]smokers, especially in public areas and maybe in newer generations) precisely because it is so great an improvement.