iOS 12 was a painful upgrade for me but the 4th erasure of the phone seems to have worked.
What this means is that I am now confident that I don’t lose anything when I erase.
So if you have good backups, just erase before the border and walk though with a fresh phone, possibly with some dummy data in there.