For general file storage spinning disk HDD are still better cost, but there is a decreasing need for general file storage for the average person. For most people one terabyte is more than enough and it may as well be an SSD that is also their boot drive.
Personally I'd love to replace my multiple 2TB drives with 8TB drives if the price comes down a bit.