Hacker News Reader

Comment by berbec | Hacker News Reader

  # Append the hidden service configuration to the Torrc file
  echo -e "HiddenServiceDir /var/lib/tor/onion-ssh/\nHiddenServicePort 22 127.0.0.1:22" > /etc/tor/torrc

Unless the '>' is changed to ">>", this will overwrite the torrc file.

View on HN

The default ubuntu torrc has everything commented out so is effectively blank anyway.

Using ">" instead of ">>" means you don't end up with multiple copies of the same hidden service.

That said, I agree: it should append, but it should first check whether it has already added a hidden service to the file.

Exactly, for simplicity since nothing is in there by default, it gets overwritten. To keep the script nice and short I decided not to add that detection. I would happily merge the change if someone decides they care enough to add it.

Maybe something like

  if [ $(grep "HiddenServicePort 22" /etc/tor/torrc | wc -l) -eq 0]

Or the more idiomatic:

  if grep -q "HiddenServiceDir /var/lib/tor/onion-ssh/" /etc/tor/torrc

I wish bash had a ternary operator for extra IOCCC-compliance.

Reply on news.ycombinator.com