Ask HN: User dependent salting? Is this good enough?

I've been using this password scheme for a while now, and I'm looking for thoughts.

salted_password(login,password) = sha1("some fixed text" + login + "/" + password + "some more salt").

Disclaimer: I've never done an industrial-class password hash, but the salts you show match my understanding of good practice. Coincidentally this was posted on HN today, and it takes issue with the hashing method rather than the salt: http://codahale.com/how-to-safely-store-a-password/

Reply on news.ycombinator.com