As a man, I agree sharing emotions is important. Too many males in society don't have someone to cry with or listen to their problems.
On the other hand, I do worry about "emotional masturbation". Simply put, sometimes we indulge ourselves in sadness/fear/anger because it makes us feel something and feeling something is better/more exhilarating/exciting than feeling nothing at all.
For example, I have some insecurities. Sometimes I feel like talking about them may be pro-actively bad because I am indulging myself and making my insecurities occupy more mental space/brain power.