When it comes to selling published work, we do have a right, not made explicit in the amendments to the Constitution, to earn a livelihood. But that right is not absolute, such that it is not permissible to earn one's livelihood by committing property crimes, violent crimes, or crimes of deception.
The agreement he signed before gaining access to state secrets is backed by laws that anticipated the possibility that someone might someday be paid to reveal those secrets, and those laws attempted to remove the financial incentive for disclosure. They include sections on review of pre-print manuscripts intended for publication, which only apply to cleared individuals.
Snowden can spill as many of his own secrets as he pleases, and get paid for them. But the state cannot allow him to profit from revealing state secrets. It's counterproductive from a security standpoint.