If they are a mechanical engineering professor at a good university, they pretty much have borne the risk of their own advice. Most people in upper-level STEM academia could easily get a higher paying job in finance/consulting and have chosen not to.
You're right it's not "a priori guaranteed," but when talking about empirical realities, what is?
A professor in a good school is like a small-business owner with a guaranteed income and a supply of free labor. In industry, the money is much better, but you're paying with your dignity and your self-respect.
Professors also likely know many other people with developed career paths that are different from their own, while a student has no career at all to draw inferences from.