If I "just" want to dim a led instead of completely cover it, you can by packs of hundreds of small circular stickers in various colours for next to nothing. I bought 400 black ones several years ago, and most leds are dimmed enough to be a lot less annoying by one of them. Some take 2-3 - especially super-bright blue leds.
But usually either one of the dots or electrical tape is what I want.
Of course I've done this to myself too. "This network switch would look cooler with purple LEDs". oops.
FWIW electrical tape transmits infrared. Not a concern here, but it can be if you're expecting it to trigger an optointerrupter!
The one that annoys me the most is my thinkpad. Apple made the slow, gentle "heartbeat" indicator when your laptop was asleep. It was a unique, delightful touch... for a while. Then everyone copied it (making it far less unique and delightful) - except they made the blinking faster, and the light red?!
Then Apple realised it was annoying and useless, and got rid of it... but everyone else kept them.
Thankfully there is electrical tape.
On the other hand with Macs now you can't tell what it's doing sometimes. Doesn't turn on, but the haptic feedback works on the touchpad? Is it just waking up from the disk? Is it hanging? Is the battery below minimum? Who knows...
The small red led on x1 carbon is my favourite.