[1] https://en.m.wikipedia.org/wiki/National_security_letter
[1] https://en.m.wikipedia.org/wiki/National_security_letter
Taken from the article you shared:
"By law, NSLs can request only non-content information, for example, transactional records and phone numbers dialed, but never the content of telephone calls or e-mails."
"Moreover, a recipient of the NSL may still challenge the nondisclosure provision in federal court."
In any case, I'm not sure that any of the protections apply to foreigners (the criticism is all about how they might accidentally target Americans) so for those who are neither Chinese nor American citizens, it makes no difference. I would be happy to be completely wrong about this if you have information about how foreign citizens' rights are protected from US intelligence gathering.
The NSLs were merely meant as an example to show how US companies can also be compelled to assist in their government's intelligence gathering. You're right that they can (in theory?) challenge the secrecy part specifically.
Did you read my comment?
The request can be fought in court, and the request does not give them access to actual contents. For example, they can NOT get the contents of an email.
Are you not aware that Apple has beaten the FBI several times in court and did not have to unlock an iPhone?
> In any case, I'm not sure that any of the protections apply to foreigners
This has nothing to do with citizens or foreigners. This is about companies. US Companies do not need to comply with US Government requests for information, Chinese companies MUST comply with ALL government requests to ALL information.
Edit: Also, regarding companies/citizens/foreigners, this is the NSA program under which it collects data from American companies and promises to only use it to spy on foreigners: "PRISM is a code name for a program under which the United States National Security Agency (NSA) collects internet communications from various U.S. internet companies ... U.S. government officials have ... defended the program, asserting that it cannot be used on domestic targets without a warrant"[1]
[1] https://en.wikipedia.org/wiki/PRISM_(surveillance_program)
This is not quite what happened. In the most famous cases, the FBI wanted (effectively) for Apple to build them a back donor that they could use as they wished. Apple argued that while it was legal for the government to demand information with a warrant, it was not legal to force programmers to write code for the FBI under threat of legal action.
Moreover the case was dismissed after the FBI admitted they could already access the phone in question, having purchased an exploit for it from a vendor.
Only on the FISA court, a secret parallel court system.
In addition, the legal challenge usually happens AFTER the letter is complied with, which makes it moot.
These letters can, and do, end up causing companies to fold (e.g. lavabit) if they refuse to comply.
Like many other national security issues (such as FISA court rubber stamps) there are theoretical checks and balances that do not tend to do much checking or balancing in practice.