Hacker News Reader

Comment by hombre_fatal | Hacker News Reader

Doesn't change the point. All of the fork's 55 PRs except 2 and most of the issues were made by the forker himself as well.

It's not like the forker inherited all the open issues/PRs, they just dropped them all.

Getting popular and having the masses leave a bunch of issues/PRs is hard. Reviewing code is hard and takes more expertise than writing it. A lot harder than reviewing your own PRs on a motivated (for now) fork.

View on HN

> It's not like the forker inherited all the open issues/PRs, they just dropped them all.

That's wrong, most of the recent commits in the fork are merging branches from a lot of other repos. GitHub doesn't have a mechanism for inheriting a project's pull requests when you fork, but that doesn't mean they're automatically "dropped", since you can still merge the corresponding branch.

https://github.com/blackjack4494/youtube-dlc/commits/master

Actually I merged quite some PRs that were open or even closed. However I tested and reviewed all I can but those geoblocked ones. But most of these were verified already or I could use some simple self hosted vpn. But do note that my reviews are not really in line with the strict coding conventions originating from the main project. As long as it works and isn't totally gibberish it will be approved by me. I rather want functionality and somewhat stability quite fast.

Although totally agree reviewing can be such a pain..

Reply on news.ycombinator.com