My Topping DAC/Amp has an optical rotary encoder for volume control and it is awful, it will randomly jump 10x the amount of steps you have rotated it, sometimes even in the opposite direction. There's something to be said for a good old fashioned potentiometer.