Because of the reported bug in this example (which I also encountered quite often):
- user hits ESCAPE
- my window gets key-down/ESCAPE and closes itself
- your window (which happens to be the next in the focus-order) gets key-up/ESCAPE and closes itself
> I also like being able to hold the key down to cue up a command and then at the right time, pull my hand away to execute crisply
Ok, but if your window wants to support this behavior (which is not very common) you have to watch for key-up AND key-down like the bug-report suggests.