I'm on a 24 month upgrade schedule mainly to benefit from improved camera tech, though I'm probably going to stop - in almost every way my current phone (Pixel 4) is a sidegrade, rather than an upgrade, to my old phone (LG V30) and I only upgraded because my old phone has gotten quite damaged - I'm very clumsy.