I'll have you know that Central Park smells like manure, not pee. The rest of the city smells like hot trash, but only in the summer ;)
Joking aside: NYC has a lot of smells, but human urine isn't actually one I pick up all that often (except for sometimes in the subway). As for why anybody would live here: it's one (maybe the most important) of the world's cultural nexuses, as well as the most thoroughly developed urban environment in the United States. Those are sufficient draws for many people.