I think "rock star" has, and is intended to have, a certain retro charm about it. A marker that those who use it are from a more civilized age (the 1980s) when songs were sung instead of spoken, when mistreating women was something you did in the privacy of your hotel room rather than the subject of your lyrics, and when writing songs about how awesome you personally are was considered a little gauche.