Worst apple product is still far ahead of most non-apple alternatives. At least laptops wise.
I needed a Mac for iOS development so I went all out since I do all sort of development - and this is by far the worst premium device I owned.
With that said M1 Macs look really good and I'll probably upgrade if they refresh the 16 inch.
But still:
1) After a few months, the screen of the thinkpad started to get permanent scratches from the keyboards. This is a common problem, see [1]
2) The keyboard is better, totally agree. But the trackpad is much, much worse. I managed to adapt to the bad keyboard on the mac, I didn't manage to adapt to the trackpad on the X1.
3) The quality of the screen has no point of comparisson. Color gamut, calibration, resolution, etc. I like the WQHD screen, but it is not available for the X1 on many countrie outside the US. In my country (Spain) you only have the UHD which is a fantastic battery draining mirror or the FHD which reminds me of the nintendo 64 when looking at it. Let's not talk about scaling hi dpi resolutions, and deciding if using Wayland or Xorg so that I can plug an external screen with different resolution, etc.
4)Battery usage is not as optimized
5) I think nowadays this is better, but at the time (around 3 or 4 years afgo) I had lots of problems on Linux with bluetooth, resuming after suspending, and the fingerprint reader. Hopefully this has improved since then.
6) Price wise, they are as expensive as an equivalent macbook
A being "good" or "bad" has a lot of aspects to it. It is not just "It has the same CPU freq and the same amount of memory then they are equivalent" (not what you're saying but something many say when doing this comparison). Build quality matters, integration/support with the operating system matters, support matters, upgradeability matters, resale value matters.
And also, just compare the f*ng mess the Lenovo website is. Every time I think about going back to thinkpad, browsing such a terrible, slow, clunky, outdated, terrible thought out website makes me regret it and just close the tab.
[1] https://www.google.com/search?q=thinkpad+screen+keyboard+scr...
Battery life is about equal on this MBP - it's just a terrible CPU for a mobile device. But more importantly I use battery about 1-2% of the time - ergonomics are just not good enough for it IMO.
X1 Yoga with an AMD CPU would be my ideal laptop but unfortunately it seems like AMD gets pushed to gamers and budget laptops still
The butterfly keyboard era Macs took a nosedive in this metric, because they were bad computers.
I have what turns out to be the last Intel 16" MacBook Pro which Apple will ever build. I suspect the Intel part of it will make its resale value kind of grim, but the keyboard, speakers, monitor, build quality: all great.
MacBooks traditionally resell at a significant premium, because they're good computers with a long useful life. I expect this will be true for the M-series as well, although it's too soon to know.
No intention to sell but I suspect resale value will stay OK as there is likely to be ongoing demand from those who want a Mac for x86 cloud development (and non-technical users probably don't care if its x86 or M1).