Well, it should be pretty straightforward to first check whether the loop is working at all and then step-by-step echo the variables for example to see what's missing.