He was a securities broker registered with FINRA. FINRA representatives have a whole lot of regulations placed on them.
To me, the main things he did wrong were, not disclosing that he is a securities professional on his channel (as opposed to just, some guy), and not disclosing his youtube channel to his employer.
> MassMutual, officially known as Massachusetts Mutual Life Insurance Company, also informed regulators that Mr. Gill gave his notice on Jan. 21 but was technically still an employee of the firm and its securities and investment advisory arm, MML Investors Services, through Jan. 28 — the week when GameStop shares surged the most.
I do think he purposefully downplayed his financial history in an aim to drive up hype, and as you stated, violated his professional obligations. At best, he walked a very thin line which will be scrutinized. At worst he broke the law and will face charges, and WSB will add a new chapter to their lore either way.