A engineer from Huawei shares details on project development process

I knew what was going on from the first look.

Back then, I was a newcomer in Huawei. I was in a depeartment, which had seven teams.

The team(A) I was in, had a very tight development schedule. After submitting the code during the day, it might take 9 pm to have time to organize a code review.

On the other hand, team B was not so busy. They had a lot of time to spare, and then started a weird competition, to PK who proposed more code review comments.

The odd thing came. I raised the pr during the day, at nine o'clock in the evening will receive more than 40 + review comments. I clicked in to see, these reviews were not from our team? How can they understand the code?

When I looked at it more carefully, I understood. All the review comments are suggestions to change the tab indentation to four spaces, if judgment when the number is written to the left, brackets without a line feed and so on and program logic irrelevant comments. Later, when we reviewed the group work, the first thing we did was to close the previous pr and resubmit. Yes, team B's dick move caused internal conflict between us.

Later. I also received a mass email that they the first place in that activity, the average day to mention 200 + comments 。。。。。

How is it related to linux community? I guess you can understand now. I saw someone said that Huawei does not clearly specify the number of pr submitted can be used for kpi appraisal. You are still too young, although the PR number is not evaluated. However, when you write on the annual report, "to participate in a certain activity/competition to get the first place", is a proper kpi.