Fair enough, but the strlen is not part of the search algorithm, it’s just figuring out the input. It could easily be an argument, but that would complicate the test code below.
String APIs are critical to the discussion of algorithm costs, e.g. removing the final character from a string is O(n) if they are null terminated, or O(1) if the string stores its size. Assuming the best of both worlds by ignoring strlen costs is hand-waving away a lot of the real world performance.
If you wanna be annoying about this, just imagine he's implementing `strnstr` instead of `strstr`.