For certain legacy things there will always be a "Visual Studio." Nobody has any interest in building a new environment for Windows Desktop application development for example.
But for web, VSCode eats VS's lunch. It is more flexible, higher performance, with a better design. So when they force Asp.net/MVC core developers to use the inferior Windows only tool, they're just shooting themselves in the foot as far as .Net adoption goes.
MSDN as a concept can stay around, but they have to start yesterday changing the thinking around it and instead of it being a "Visual Studio + Benefits" it is "Benefits + Services + Legacy Visual Studio."
MSDN could include a half dozen premium VSCode extensions today, but they're stuck in this 1990s product thinking modality. Microsoft went "services, services, services" back in 2007, except the Developer Division and that has to change now.
If they were service/benefit focused instead of product, they wouldn't even care about Rider existing and their goal would be to get "Rider + MSDN" subs because the value add would be high enough to justify it. Or heck release premium Rider extensions (identical to VSCode) that require MSDN (and or premium CLI-based functionality).