So you are saying that Apple has access to all your data ( = no privacy ) but this "app" will improve your privacy by scanning all your files.
But yes, currently Apple can access all your images on the cloud, but with this change they would have been E2E encrypted, hence improving privacy.
Apple said nothing at all this would be the case. It's pure speculation from people on the internet.