In short: Glass-Steagall was about separating commercial banks from investment banks. Of course, in 2008, pure investment banks largely failed. In any case, banks already naturally separated from diseconomies of scope[1].
The reality is that the G-S repeal was a completely harmless symptom of a more harmful disease: general banking deregulation (and a push against new regulations) in the late 1990s and early 2000s (yes, it was bipartisan in both Clinton and Bush years).
[1] https://www.minneapolisfed.org/article/2010/scale-economies-...