There is actual peer-reviewed research about what makes a good software engineer which you can find easily with the right tools. This 2015 paper using a sample set of 59 Microsoft engineers across different divisions is one such study: https://faculty.washington.edu/ajko/papers/Li2015GreatEngine...

My experience in the industry is that no one in charge of either hiring or promotion is aware of the research, and have chosen to structure the systems that support them without data and prone to biases. The most bizarre aspect of our industry is that there is a high emphasis on work output, whether that be measured in LOC, number of PRs, number of releases, number of "story points," etc. or another measure, and yet low value of those same metrics in promotion processes.

I don't actually think those are great metrics to base career advancement on, but the contradiction is egregious.