The documentation looks really nice, and it’s extremely rare for a company to provide any printed material with their hardware, other than the multi language safety card. Many will just provide a basic how-to support page to get you along your merry way, but this looks superb, and a great way to get people learning. I wouldn’t be surprised if the bulk of development costs lie in that book.
The will also be providing firmware updates, patches and quality enhancements, which are likely to be much better than your open-source project in GitHub with a moderate client base.
something like the labjack u3 would probably suffice with a bit of signal conditioning. (and learning how to do that would be way more educational and relevant than snapping together a no-solder kit.)
At the end of day for people who will actually use it convenience probably beats other factors and having exactly right set of features, ability directly plug audio connectors, UI and software optimized for audio workflow can be preferable even if comparing raw specs and build quality to electronic tools makes it feels like a cheap DIY/kit or toy.
A 100MHz instrument scope like that HP is way overkill for such a purpose and will have an overwhelming number of controls and features. Worse, it will be easy to get it in a state where nothing is appearing and you have to fiddle with buttons to just see a waveform-- this is NOT something a musician wants, not ever, and especially not when live.
Compared to it and the Mordax Data, the Korg offering is interesting.
Personally, I use an Expert Sleepers ES-9 connected to my laptop with VCV Rack scopes and spectrum analyzers. The ES-9 is a great Swiss army knife module, albeit greedy on the +12V rail and somewhat costly. I'm still longing for a proper 4 channels scope.
you don't get to define "garbage" for everyone.