Photos generally won't get much compression anyways since the image data is already compressed. However in general yes, zstd is almost always preferable to gzip these days.
For archiving RAW files, yes.
For RAW --> lossy format, storing them in JPEG-XL would be preferable, and I doubt most compression algos would do better than JPEG-XL.