Laege scale thermal storage has surprisingly low losses to the point where a 10GWh scale system can disregard them over a year. Cube square helps a lot here.
Your heat engine is where you lose all the energy.
Batteries are great and getting better. There's a reason most storage uses them, but they're ill suited to multi month storage due to cost. The best contender here is chemical fuels (which have similar efficiency penalties).
Energy vault is, at best, a very poor subsitute for batteries. A 1000 tonne block on top of a 500m tall stack can store $20 worth of solar energy and might sell it for $80. If you use it annually, then you get $60/yr. If you use it 1000 times a year it might be viable compared to current generstion batteries, but that will change quickly as there's no real way to make it more economical. Ignore it and tell anyone who suggests using it as anything other than 4hr storage they're probably being scammed.
Thermal batteries are the budget option. You can store about 5-20Wh/kg in whatever thing that's lying around that doesn't turn into a gas or become too corrosive. By every other metric they are terrible, but they are, in the most literal sense possible, dirt cheap (although you generally use low grade sand or maybe water because dirt is too valuable).
The use case is mostly providing very cheap heat with energy that is not valuable enough to store with other methods. Insofar as using the concept for work (where the efficiency penalty lies), the logic would probably be something like:
-- I have free energy noone wants (curtailed wind during midday summer)
-- I have free sand noone wants (someone dug a hole and wants to get rid of it), but it costs me a little more to move it and build a silo than I will get paid to dispose of it.
-- I have a free steam engine with its exhaust hooked up the district heating noone wants (a coal generator went bankrupt because renewables replaced it).
I'll put the heat in sand, then make steam with it in winter (extracting 20-30% of the original energy as work), then pump 50-60% of the original energy into homes as heating (losing about 20% in the pipes and steam engine and some during storage).