I added grain to an image pipeline that's fairly widely used (millions of devices). I found that simple poisson noise in linear space with a bit of filtering gives a decent natural look with very low complexity.
That’s my experience as well, as a visual effects compositor, and responsible for quality control on a few large budget movies. Some artists had fancy methods for adding grain back on their images, but besides some control on the intensity based on the luminance, basic poisson noise is enough to match almost every digital or analog film scans.
Stupid question - do you generate different patterns of poisson noise on every frame?
As they grain of each film frame is independent, you should but there are many techniques to avoid that, generate larger noise texture than your target size and use it with random offset, additionally you randomly mirror it in either direction.
I do, it's fast enough and done with integer arithmetic. I have seen others use pre-generated noise patterns.
I'd love to know more about your approach here... Do you have any resources you could point to if one wanted to learn more?