After you get the hydrogen atoms separated from the oxygen, the oxygen atoms bond to become O2 molecules, releasing heat uselessly, and will later need to separated again (other oxygen, of course) when you burn the hydrogen, consuming much of the released energy; and likewise for hydrogen molecules.
The recent story about using water vapor as the feedstock might signal a solution to the impurities and erosion problems that introduces new problems to solve before it can be used.
Efficiency of the process is becoming unimportant as the cost of solar and wind-generated energy continues rapidly down, making other things like the cost of equipment and the volume of production more important.
The frequent reports on improvements to electrolysis indicate not hype, but research cumulatively improving an important process, just as improvements in production techniques drove and still drive down the cost of solar panels.