For example, if you "guess" that a certain type of lens would be better for certain types of infrared imaging, and publish this, you have potentially violated the US export control / international traffic in arms regulation (ITAR) by "exporting" that design to the wider public.
It's easy to complain about that, but widely publishing information on highly effective weaponry is (I hope) clearly a bad idea, lest some rogue actor start shooting down airliners for fun.
That’s how our legal system works. Waxing poetic with no authority to enforce the poetry risks implanting false reality in readers heads.
Are we at war? When did it start? When will it end?
Somehow you have claimed that a war we're not fighting with people who couldn't benefit from knowledge of information that isn't secret justifies charging this guy with espionage. One would marvel that anyone could be so incoherent, except this is the typical result of consuming American corporate war media content.
I think modern technology has made things a bit less clear-cut in some ways, because advances in technology have made a lot of things that were previously military secrets (e.g. troop movements) arguably not secret anymore (the enemy obviously already knows where that army is, it's clearly visible by their satellites). I think aircraft hidden in Area 51 definitely don't fall into that category though.