The question was being asked early. It came into public focus even before the Challenger loss, as the shuttle program struggled to come remotely close to promised flight rates (which of course it never did). The cover story of the November 1985 issue of Discover magazine had this cover blurb:
"The shuttle is a superb technological achievement, and it's flown by brave, immensely competent men and women...
But what's it good for?"
https://i.ebayimg.com/images/g/oFwAAOSwgDZjI0Av/s-l500.jpg
The article was pointing out that going with cheaper expendable launchers would have been a much, MUCH better idea. And so it proved.
(This article is one of the reasons I wrote "largely" in the comment above.)
At any point after this article came out, cheerleading was irresponsible.
Journalists might be forgiven for not predicting how uneconomic the Shuttle would be to operate, at least before this became painfully obvious a few years in. Even the critics on Capitol Hill like Mondale and Proxmire missed that; they focused more on development cost. But the Shuttle would have been a failure even if the development cost was zero.