A number of people saw this and said that making a breaking change to the repo that a lot of people are using and have forked for other models was a bad idea, thus this new PR.
A number of people saw this and said that making a breaking change to the repo that a lot of people are using and have forked for other models was a bad idea, thus this new PR.
The PR it linked to said nothing of the sort: https://github.com/ggerganov/llama.cpp/pull/613
How is that productive? The author already claimed in their changes that they aren't an ML expert and asked for advice.
It could be written like
multi-headed attention transformers frobnicate all the weights in their QKV matmuls. <supposition ... I would look at IO rates during inference ...>
You have an opportunity to teach rather than admonish.
[1] https://github.com/ggerganov/llama.cpp/discussions/638#discu...
that's it
In this use of mmap, there is nothing to swap out as the source of truth is always on disk. During general swap usage, memory has to travel in both directions.