I think the parent means losing the magnetic surface dock connector from the new dock, rather than losing magnetic attraction over time. They may way to clarify though.
Which Apple usb c hub are you referring to? The multiport adapter?
Yeah, the "USB-C Digital AV Multiport Adapter". I have zero concerns about the lifespan of the USB connector.