It was wildly successful.
You're just under the mistaken impression that the goal was to go to space cheaply or whatever.
But the success of the shuttle program pales in comparison to the SLS and Artemis.
Now they're spending more money in all the right places, without that pesky distraction of launching the thing into space.
You're way off in the wonderland considering the goals and achievements. Just remember who's the actual goal setter is. Don't fool yourself.
But so what? I don't care about that measure of "success". I care about reliable, reusable, cost-efficient space launches, and all the technological and scientific advances that can bring. By those measures, the space shuttle was a disaster of a failure. That's what we care about.
In other words, a lot of such government-backed projects utterly fail in their objectives, not so much due to lack of prophetic foresight, but due to inability to re-evaluate when it becomes clear that the previously chosen approach can no longer lead to the envisioned outcome. ITER is another fine example of this.
The original STS design looked a lot more like late-game KSP1 (possibly depending on the player).
The Saturn V could get 44.5 tons to the moon.
So instead of the shuttle program we could have had whatever amount of moon base you'd get with just under 7500 tons on the moon.
And that's assuming a very expensive Saturn V, in reality the system would have become cheaper over time due to optimization and amortization.
You learn to do things better by doing it repeatedly. The best way to build up to weekly launches is to do it more and more and more often, which is exactly what SpaceX has done.
Stopping the funding that NASA was getting at the time is the reason we lost those institutional muscles and stopped building them up.
Possible bad wording on my part. I meant that the cost was hardly sustainable in a long run, so that once it was clear that the US had won the race to the Moon, the lack of significant incentives doomed the project because of high cost compared to the return. Back then there was no or very little interest in placing commercial satellites in orbit and nobody cared about Mars. The shuttle was different as it served as a lab and carrier to put satellites in orbit, and more importantly (replying also to avar here) disasters aside one would still have the shuttle returning after each launch, while every single Saturn V had to be rebuilt. I believe the move to a reusable carrier was obligatory to make short term launches feasible economically, which is what the Shuttle started and now SpaceX is continuing.
The per launch cost was the same when dividing the overall cost by the number of launches. Saturn V launched 13 times, the shuttle 135 times.
There's just no way to rationalize the whole project not being a terrible idea from beginning to end.
The story that NASA was too expensive during Apollo sounds like political spin to me.
The true problem is that the US government stopped funding space in a serious way and so NASA did not continue pushing the envelope at the rate they did before. We've had some pretty great robotic missions in that time though.
To build reliable, economical rockets and spacecraft (at least those burdened with the task of escaping Earth's gravity well), you need to be able to intensely specialize and streamline them to the greatest degree possible, with what complexity remains pulling its own weight several times over. They need to be really good at one thing, with any other use cases coming as a bonus.
It took SpaceX to slash costs, accelerate development, and choose an approach that really made engineering success to push partial reusability over the finish line. SpaceX was not subject to the perverse incentives under which NASA is forced to operate.