You’re right, technically VPN is not illegal, as long as the operators abide laws. It is using VPN to get across GFW that is illegal: https://m.sohu.com/a/738815891_800907/?pvid=000115_3w_a#:~:t...
So, yeah, it is practically illegal to use VPN in China.