My parents had various timeshares and got good holidays from them and were generally happy, so I don’t think they are by default a scam.
We still go to one 30 years later, and the maintenance is about 1/3 of what you’d pay for an equivalent hotel room (€1,000 vs €3,000) so I think overall they are “up”.