Me and the other senior dev spent weeks reviewing these PRs. Here’s what we found:
- The feature wasn’t built to spec, so even though it worked in general the details were all wrong
- The code was sloppy and didn’t adhere to the repos guidelines
- He couldn’t explain why he did things a certain way versus another, so reviews took a long time
- The code worked for the happy path, and errored for everything else
Eventually this guy got moved to a different team and we closed his PRs and rewrote the feature in less than a week.
This was an awful experience. If you told me that this is the future of software I’d laugh you out of the room, because engineers make enough money and have enough leverage to just quit. If you force engineers to work this way, all the good ones will quit and retire. So you’re gonna be stuck with the guys who can’t write code reviewing code they don’t understand.