Const whenever possible.
What are other considerations?
But thinking through the example
function expectedRevenuePerAttempt() {
(const/let) successRate = success / attempt;
return successRate * revenuePerSuccess
}I would prefer to use const there.